Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An action returning a nonzero exit status is currently stored in the ActionCache and returned by later Execute requests without another attempt. A transient sandbox/tool failure can therefore persist after its cause has been fixed.
Return unsuccessful execution results to the caller without caching them, and ignore unsuccessful entries already present in the cache. Preserve cancellation and
do_not_cachebehavior. Rename the publishing helper to reflect that it handles both successful and unsuccessful results.The regression checks cover exit codes 1, 127, and 137 and verify that they are returned without creating an ActionCache entry. A native REAPI probe also verified retrying a previously failed action.
Validation was performed with these fixes combined in a Linux KVM integration workspace, using actiond for execution and caching. The native unit suite, filesystem probes, and a large mixed-language Bazel workload passed. These draft changes have not been validated with
tools/e2e.sh vmon macOS.